Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displaying all possible keys for a combo in the cheatsheet #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Displaying all possible keys for a combo in the cheatsheet #240

wants to merge 1 commit into from
+58 −22

Conversation

rerodrigues
Copy link

Hi @chieffancypants I've changed the format function to allow displaying all possible keys for each combo in the cheatsheet.

A possible usecase could be, for example, when you want to create shortcuts using keys that doesn't exist in all platforms.

hotkeys.bindTo($scope)
  .add({
    combo: ['home','alt+left'],
    description: "Go to beginning (PC/Mac)",
    callback: function (event, hotkey) {
      $scope.goToBeginning();
  }
});

It will now display both shortcuts on the cheat sheet.

@rerodrigues
Copy link
Author

rerodrigues commented Jul 14, 2016 •
edited
Loading

I also upped the karma-phantomjs-launcher version to 1.0.1 to fix the unsolved peer dependency error for phantomjs@>=1.9

@rerodrigues rerodrigues mentioned this pull request Aug 18, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rerodrigues